feat: Enhanced pgBackRest Support (Sidecar Architecture)#8268
Closed
SBALAVIGNESH123 wants to merge 1 commit intocoollabsio:v4.xfrom
Closed
feat: Enhanced pgBackRest Support (Sidecar Architecture)#8268SBALAVIGNESH123 wants to merge 1 commit intocoollabsio:v4.xfrom
SBALAVIGNESH123 wants to merge 1 commit intocoollabsio:v4.xfrom
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
SBALAVIGNESH123
force-pushed
the
feat/pgbackrest-support
branch
from
1c98221 to
6ccc1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve merged the latest changes from v4.x into the branch, ensuring that our pgBackRest implementation remains intact. The merge conflicts in StandalonePostgresql.php were handled manually to preserve the new backup logic while pulling in the upstream model updates, and I accepted the incoming changes for all other unrelated files to keep things clean. I also took the time to address the GitGuardian alert by sanitizing the test credentials and did a quick polish pass on PgBackrestService.php
to remove some verbose comments, so the code looks much more professional now. Everything builds and passes local checks, so it’s ready for review